can anybody help me to fix my code i am trying to get default out put else "name is NOT listed" but evey time I run the program i cant get it thank u ============================================ echo "Enter the first letter of the name to look up, or q to quit" read name while [ $name != "q" ] do echo "Do you want to list all names start with $name {y|n} ?" read choice if [ $choice = "y" ] then grep -i "^$name" /home/students/atammf/lab1/phonebook.list; elif [ $choice = "n" ] then echo "Enter the full last name to look up: " read name1 grep -i -w "$name1" /home/students/atammf/lab1/phonebook.list; else echo "Name is NOT Listed" fi exit 0 done

Try the following syntax if you are using a POSIX or Korn shell if [[ $choice = "y" ]] i.e. [[ ..]] instead of [ .. ] If you are using csh/tcsh or similar, try if [ "$choice" = "y" ]

Hi Fanco, One Basic thing I see is, while comparing strings on UNIX, its always a good idea to cover it with " like this while [ "$name" != "q" ]; then... In the script that you have mentioned, the fact that $name is empty will transfer your script to something like this while [ != "q" ] and will result in a syntax error. Hope this helps. -- MeMyselfAndAdi