can somebody look at this and tell me why it loops once extra when reading back from the saved files? void WeatherStation::SaveToFile() { fstream OutFile(FileName.c_str(), ios::out); for(int K = 0 ; K < Station.size() ; K++) { OutFile << Station[K] << endl; OutFile << Agents[K] << endl; OutFile << Temp[K] << endl; OutFile << Highs[K] << endl; OutFile << Lows[K] << endl; } OutFile.close(); } void WeatherStation::ReadFromFile() { fstream InFile(FileName.c_str(), ios::in); string Buffer; double Bufferint; while(!InFile.eof()) //Check to see if you're at the end of the file... { getline(InFile, Buffer); cout << "Buffer1 = " << Buffer << endl; Station.push_back(Buffer);//storing information getline(InFile, Buffer); cout << "Buffer2 = " << Buffer << endl; Agents.push_back(Buffer); InFile >> Bufferint; cout << "Buffer3 = " << Bufferint << endl; Temp.push_back(Bufferint); InFile >> Bufferint; cout << "Buffer4 = " << Bufferint << endl; Highs.push_back(Bufferint); InFile >> Bufferint; cout << "Buffer5 = " << Bufferint << endl; Lows.push_back(Bufferint); InFile.ignore(100, '\n'); //Flush the buffer after a numeric input... }

while(!InFile.eof()) //Check to see if you're at the end of the file... This does not do what the comment describes. You don't know that you are at the end of the file until you actually try to read past the end and fail. Compare that with the old Pascal idiom which is similar to what you have here. In Pascal, when you check for eof(), the runtime tries to read a character from the file "behind the scenes" and tells you if it is at the end. If it is not at the end, it saves that character in a buffer, and returns it next time you ask to read a character from the file. C and C++ don't have this look-ahead feature. You need to recode your function so that it checks the values returned by getline. (Or check with eof() after calling getline.)

can i still use these vector lists to do that? or do i need to change my whole program? or do you know if theres a code i can just replace with? btw. thanks for replying!

What "vector lists"? All you need to change is function ReadFromFile, I see neither vectors nor lists in there. You can keep the same local variables. To make the logic easier to understand, you might want to write an additional function (pass it the fstream as an argument) that reads one record from the file and returns a boolean to tell you whether it's succeeded or not. You can then call the new function in the while loop.

so im looking to do something with pascal kind of?

im looking at a tutorial that talks about posttesting and while loops which is i think a during loop? for this function, do you think it would be more efficient/effective to do one during or after?

Replace: while(!InFile.eof()) //Check to see if you're at the end of the file... { getline(InFile, Buffer); With: while (getline(InFile, Buffer)) {