Hello all,

I need urgent help please. I have been trying for hours to pass a variable between two for loops in order to compare the strings passed and excute a statement. Here is my code

@echo off
SET count=1
FOR /f "tokens=*" %%A IN ('dir C:\po\*.!Consolidated /b') DO (call :s_do_sums %%A)
GOTO :eof
:s_do_sums
set "str=%1"
set str=%str:~6,4%
echo.%str%
set /a count+=1
GOTO :sub2
:sub2
FOR /f "tokens=*" %%G IN ('dir C:\lo /b') DO (call :s_do_sums1 %%G)
GOTO :eof
:s_do_sums1
set "str=%1"
set str1=%str:~0,4%
echo.%str1%
set /a count+=1
if %str1%==%str% (
xcopy %str%*.*.* C:\po
)
GOTO :eof

I need to compare the existance of the two files that are on separate folders before I can copy the filename into a different folder.

Thanks

Not easy to follow someone else's code.. I can't even follow my own. LOL

A couple things:

II would do a set /a each tiime. NOT a plain set.

I think you are usiing the var str in both subs and they may be clobbering each other.

I almost always use:

setLocal EnableDelayedExpansion

then use vars as !count! etc.

If the purpose is to copy only files that exist, you can:

xcopy /U

But that's not what you asked.

=====================================
If at first you don't succeed, you're about average.

M2

what exactly are you wanting to do? can you describe?

I agree with M2, it's not easy to follow the code, but I think you are setting str in sub :s_do_sums1 when I think you intended to set str1.

It works,

Using set with param /a and giving a new name to my string resolved it.

Thanks a lot 4 ur help

Kyser

I would still think about M2's suggestion and ghostdog's question. There's probably a better way to do what you want to do (such as xcopy /u).

As a mather a fact, I used move on the file.
To be more precise: this small script compare two files that have different filenames but a number with 4 digits in common. On the first filename the number is found at the 6th position and on the second filename it's at the begining. if the first file is consolidated I compare it to the second file then I move the second file to a different folder.

Hope this makes it more clear.