But if I use a goto :eof will it not go beyond the for loop and not loop around?

0

After the CALL it returns to the FOR loop. ===================================== If at first you don't succeed, you're about average. M2

0

It doesn't appear to be doing so. It works fine for the first entry in the Stores.ini (List of servers) but then just stops. Here is the code with the GOTO :EOF entries. @echo on SetLocal EnableDelayedExpansion FOR /F %%i IN (Stores.ini) DO ( SET SERVER=%%i CLS ECHO Connecting to %%i ... REM ##############PING AND MAPPING####### PING -n 1 %%i >nul IF !ERRORLEVEL! == 1 GOTO PINGFAIL NET USE /D V: /Y >nul NET USE V: \\%%i\g$ /USER:DEBENHAMS\Administrator leaving IF !ERRORLEVEL! == 2 GOTO LKFAIL REM ############################ REM DFS REM #######DFS FILE####### ECHO Checking for DFS file... IF NOT EXIST V:\USR\OSCAR\DFS\osc%date:~0,2%%date:~3,2%%date:~6,4%.txt GOTO FAIL1 REM ############################ REM OML REM #######OML FILE####### ECHO Checking for OML File... IF NOT EXIST V:\USR\OSCAR\LOGS\%date:~6,4%%date:~3,2%%date:~0,2%.OML GOTO FAIL2 ECHO Checking for successfull SOD in %date:~6,4%%date:~3,2%%date:~0,2%.OML FINDSTR /I "StartOfDaySuccess|YES" V:\USR\OSCAR\LOGS\%date:~6,4%%date:~3,2%%date:~0,2%.OML IF NOT !ERRORLEVEL! == 0 GOTO SODFAIL REM ############################ REM EJ REM #######EJ FILE####### ECHO Checking for EJRL File... IF NOT EXIST V:\USR\OSCAR\WORK\%date:~0,2%%date:~3,2%%date:~6,4%.ej GOTO FAIL3 GOTO SUCCESSFINISH REM ############################ :PINGFAIL ECHO %SERVER% Is off the network. >>Results.txt GOTO :EOF :LKFAIL ECHO %SERVER% Unable to map drive. Check Lifekeeper drive permissions and Share access. >>Results.txt GOTO :EOF :SODFAIL ECHO %SERVER% OML File exists, but successfull SOD flag not present. Check Errlog. >>Results.txt GOTO :EOF :FAIL1 ECHO %SERVER% OSC File missing for todays date. Check Errlog and OML file >>Results.txt GOTO :EOF FAIL2: ECHO %SERVER% OML file does not exist. Check Errlog >>Results.txt GOTO :EOF FAIL3: ECHO %SERVER% EJ file does not exist. Check Errlog and OML file >>Results.txt GOTO :EOF :SUCCESSFINISH ECHO %SERVER% Start Of Day SUCCESS >>Results.txt GOTO :EOF :FINISHFAIL ECHO Finished Checking %SERVER% GOTO :EOF ) EndLocal

0

re-read #3 ===================================== If at first you don't succeed, you're about average. M2

0

Post #3 is referring to my Ping function (which ERRORCHECKS fine, it outputs different !errorlevel!'s dependant on what happens. Maybe I am not unerstanding this correctly, please could you explain it so me more, or perhaps adapt my script partly? Thanks.

0

My PING returns 1 for a non-existent IP, but 0 for an unresponsive one. I'd be surprised if the PING in XP is different from PING in W2K. Here's the MD5 hash for W2K PING.EXE: f837281900f3793f6d38d5994a3ed319 ===================================== If at first you don't succeed, you're about average. M2

0

All devices that will be in Stores.ini will all be ones taken from DNS. The ping feature is not my issue, the fact that the GOTO's do not work within my FOR loop doesn work is. I need to know how to resolve this with another method. Whoever can give me an alternate method, could you please adapt part of my script so I can see how it would work.

0

The ) ending your FOR is near the bottom, just before EndLocal. I think you need it after this line: IF !ERRORLEVEL! == 2 GOTO LKFAIL ===================================== If at first you don't succeed, you're about average. M2

0

But then the rest of the script wouldn't work for the different devices in Stores.ini It would render everything after that pointless and not included within the loop. I want ALL of the script to work for EVERYTHING in Stores.ini

0

Then I think you want to CALL the :sub instead of GOTO. ===================================== If at first you don't succeed, you're about average. M2

0

CALL doesn't work, because after the CALL it carries on from the :sub instead of calling the :SUB and carrying on. If i move the order of the :sUB to after each procedure it will run it, regardless. Any other suggestions?

0

CALL doesn't work, because after the CALL it carries on from the :sub instead of calling the :SUB and carrying on. That's where GOTO :EOF comes into play. If i move the order of the :sUB to after each procedure it will run it, regardless. I have no idea what you're trying to say.

0

GOTO :EOF doesn't work, you can see my code above and test it if you wish. It doesn't work because it goest to the end of the script, and doesn't loop again past the first entry CALL call's the :SUB and then continues through the script, it doesn't return to where the CALL is and continue. EG. If you see where the ping feature is, it would call the :PINGFAIL SUB and then continue through the rest of the script. Any other suggestions?

0

Yeah, use both CALL and GOTO :EOF, just like we've been telling you to for the past, what, 5 days now?

0

I chopped out much of the REM and the %date% stuff. I don't have a network so I can't get a 'success' but hopefully this will give you some ideas on how to proceed. ::========================= @echo off SetLocal EnableDelayedExpansion FOR /F %%i IN (Stores.ini) DO ( SET SERVER=%%i ECHO Connecting to %%i ... PING -n 1 %%i >nul IF !ERRORLEVEL! == 1 call :PINGFAIL NET USE /D V: /Y >nul NET USE V: \\%%i\g$ /USER:DEBENHAMS\Administrator leaving IF !ERRORLEVEL! == 2 call :LKFAIL IF NOT EXIST zzzz call :FAIL1 call :SUCCESSFINISH ) goto :eof :PINGFAIL ECHO %SERVER% Is off the network. >>Results.txt GOTO :EOF :LKFAIL ECHO %SERVER% Unable to map drive. Check Lifekeeper drive permissions and Share access. >>Results.txt GOTO :EOF :SODFAIL ECHO %SERVER% OML File exists, but successfull SOD flag not present. Check Errlog. >>Results.txt GOTO :EOF :FAIL1 ECHO %SERVER% OSC File missing for todays date. Check Errlog and OML file >>Results.txt GOTO :EOF :FAIL2 ECHO %SERVER% OML file does not exist. Check Errlog >>Results.txt GOTO :EOF :FAIL3 ECHO %SERVER% EJ file does not exist. Check Errlog and OML file >>Results.txt GOTO :EOF :SUCCESSFINISH ECHO %SERVER% Start Of Day SUCCESS >>Results.txt GOTO :EOF :FINISHFAIL ECHO Finished Checking %SERVER% GOTO :EOF ===================================== If at first you don't succeed, you're about average. M2

0